AHBToTL: add a register to retain hrdata during an error response #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been deemed desirable to output the data value of a read response which fails, hopefully reducing confusion for people looking at waveforms. The AHB spec does not require this and vendor VIP does not test for this. Therefore, two changes were made to confirm this additional requirement is met: - The AHBToTL block has an assertion that hrdata is steady during an error response - The scoreboard fuzzer now checks that corrupt read data matches what was written I have confirmed that both assertions fire when the hrdata register is removed.
daveparry
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Change looks fine to me, but the Title on the Commit and PR is a bit confusing. I realize that this is for read response data being passed from TL to AHB, but since the change is to the AHB2TL bridge, should the title be "ABHToTL: ..." rather than TLToAHB:..."?
terpstra
changed the title
|
You are correct. Fixed. |
mwachs5
pushed a commit
that referenced
this pull request
Jun 24, 2020
) It has been deemed desirable to output the data value of a read response which fails, hopefully reducing confusion for people looking at waveforms. The AHB spec does not require this and vendor VIP does not test for this. Therefore, two changes were made to confirm this additional requirement is met: - The AHBToTL block has an assertion that hrdata is steady during an error response - The scoreboard fuzzer now checks that corrupt read data matches what was written I have confirmed that both assertions fire when the hrdata register is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been deemed desirable to output the data value of a read response
which fails, hopefully reducing confusion for people looking at waveforms.
The AHB spec does not require this and vendor VIP does not test for this.
Therefore, two changes were made to confirm this additional requirement is met:
I have confirmed that both assertions fire when the hrdata register is removed.
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation