Preserve literal value across .asSInt and .zext #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
force-pushed
the
asSInt-literal-preservation
branch
from
e32aedc
to
37c416d
Compare
seldridge
approved these changes
Jun 6, 2024
Comment on lines
+781
to
+784
| def do_zext(implicit sourceInfo: SourceInfo): SInt = this.litOption match { | ||
| case Some(value) => SInt.Lit(value, this.width + 1) | ||
| case None => pushOp(DefPrim(sourceInfo, SInt(width + 1), ConvertOp, ref)) | ||
| } |
There was a problem hiding this comment.
It is somewhat surprising that zero extending a UInt returns an SInt. I would've thought that this took a width to zero extend to and did not change the type. This seems like it wants to be asSIntPreserveValue or something. This is what the API is, though.
There was a problem hiding this comment.
I agree the name of the API is questionable but that's what it has always been. We certain can alias it (and consider changing).
jackkoenig
force-pushed
the
asSInt-literal-preservation
branch
from
37c416d
to
bb9a996
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
(cherry picked from commit dbbf73a)
14 tasks
chiselbot
pushed a commit
that referenced
this pull request
Jun 6, 2024
(cherry picked from commit dbbf73a) Co-authored-by: Jack Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
.asSIntis only defined onBits, if you want to cast toSIntfrom Bundles or Vecs you already gotta go throughUInt.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.