Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve literals across .asUInt #4148

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Preserve literals across .asUInt #4148

merged 1 commit into from
Jun 6, 2024

Conversation

jackkoenig
Copy link
Contributor

Also working on supporting preserving literals across .asTypeOf, but this is the first step.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

This is mostly useful for initial values for async reset registers and for constructing literal values in testing contexts (e.g. ChiselSim). It also should slightly reduce memory use and .fir size.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Jun 6, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jun 6, 2024
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks correct to me. This is a nice improvement.

The tests are quite verbose. I don't have a good suggestion on how to get them smaller, though.

@jackkoenig jackkoenig merged commit d35daa2 into main Jun 6, 2024
15 checks passed
@jackkoenig jackkoenig deleted the literal-preservation branch June 6, 2024 21:08
@mergify mergify bot added the Backported This PR has been backported label Jun 6, 2024
@jackkoenig
Copy link
Contributor Author

The tests are quite verbose. I don't have a good suggestion on how to get them smaller, though.

Yeah me neither, especially because I think it is important to check weird Bundle Literals

mergify bot pushed a commit that referenced this pull request Jun 6, 2024
(cherry picked from commit d35daa2)

# Conflicts:
#	src/test/scala/chiselTests/SIntOps.scala
chiselbot pushed a commit that referenced this pull request Jun 6, 2024
* Preserve literals across .asUInt (#4148)

(cherry picked from commit d35daa2)

# Conflicts:
#	src/test/scala/chiselTests/SIntOps.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants