Apply scalafmt #2246
Merged
Apply scalafmt #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sequencer I've pushed over this. I integrated your 3 commits into 1 (adding the ability to run scalafmt), then there are 2 more commits: 1) Running scalafmt on everything, and 2) turning the check on in CI. This is failing Mergify because some features were deprecated and removed so we need to fix that before we can merge any PRs now.... |
|
Note that this must be merged with a merge commit because we need different commits for making it possible to run scalafmt and actually running it. Separating these commits allows people to more easily update branches from before the formatting was applied without massive merge conflicts. The process is as follows:
Voila, merge conflicts have been avoided. |
jackkoenig
added
the
Merge with merge commit
Can be run in two ways: * sbt scalaFmtAll * mill mill.scalalib.scalafmt.ScalafmtModule/reformatAll __.sources
Command: sbt scalafmtAll
seldridge
approved these changes
Jan 10, 2022
jackkoenig
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time(Clean up before 3.5) to apply scalafmt!