Automatically handle DeveloperID certificates. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than keying off the "ACTION" environment variable, we can key off the fact that it is a DeveloperID certificate - which causes the binary to be signed with a different Designated Requirement. Previously, the Developer ID designated requirement was used only when ACTION was set to "install". This change keys off of the certificate CN, and if it is a Developer ID certificate, it will generate the strings appropriate for that signature.
|
For some reason I didn't get a notification that you had already submitted this. Thank you. On first glance it looks good. Before I merge it though, I want to go through it one more time, and also check to see if anything needs to be updated in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than keying off the "ACTION" environment variable, we can key off the fact that it is a DeveloperID certificate - which causes the binary to be signed with a different Designated Requirement. Previously, the Developer ID designated requirement was used only when ACTION was set to "install". This change keys off of the certificate CN, and if it is a Developer ID certificate, it will generate the strings appropriate for that signature.