Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: unit test for features controller and services #220

Merged
merged 15 commits into from
Nov 7, 2024

Conversation

Ajen07
Copy link
Contributor

@Ajen07 Ajen07 commented Nov 3, 2024

Description

  • Unit tests for Feature controller and Services

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tested with yarn test:docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 requested a review from cherylli November 3, 2024 10:19
@Ajen07 Ajen07 self-assigned this Nov 3, 2024
@Ajen07 Ajen07 added the review label Nov 3, 2024
Copy link

github-actions bot commented Nov 4, 2024

@cherylli
One business day has passed since the review started. Give priority to reviews as much as possible.

@Ajen07 Ajen07 requested a review from timDeHof November 4, 2024 18:00
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed. But I added a suggestion for the dates for createdAt and updatedAt

src/features/features.service.spec.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. went through the code and ran all the tests, no issue.

@timDeHof timDeHof self-requested a review November 7, 2024 01:26
Copy link
Contributor

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. Thank you for making that change.

@Ajen07 Ajen07 merged commit 7f8b671 into dev Nov 7, 2024
1 check passed
@Ajen07 Ajen07 deleted the test/unit-test-features branch November 7, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants