Linting formatting additions #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2020 21:35
turning on the eslint recommended rules integrating prettier extension with eslint allowing jsx in js files adjusting import/resolver settings as eslint wasn't able to find next.js imports
ghost
requested review from
ZumDeWald
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So @ZumDeWald and I were talking the other night about issues with eslint and prettier for the front-end. I went through and added some rules to help with the errors he was seeing.
This PR adds eslint recommendation to the base eslint extensions as well as prettier integration for eslint.
It allows JSX in .js files which was the reason every line had a red underline in Atom
And a more subtle problem was that imports weren't being resolved by eslint so I added a settings property that takes care of import/resolving issues.
The two things that are still showing as problems for eslint are prop-validation which is something airbnb wants (this can be easily turned off but I didn't want to make that decision for the team as a whole) and also because the a11y eslint plugin was already installed I'm assuming we want to be a11y conformant. A problem with Next.js is how they handle anchor tags. There is already a discussion that hasn't made much head way on their repo vercel/next.js#5533. This rule, I image, can be turned off as well so we don't get the red underline indication that our project is horrible in some way, but I felt we should discuss it as a team as well.