Add main key to package.json #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a main key to package.json for webpack with package splitting
|
For those of us that wish to do webpack vendor splitting based on our package.json file since your package is named like a file without a main key webpack treats it as a file not a directory. |
Closed
|
@chinchang any luck on getting this merged, I'm running into this issue as well. Thanks! |
chinchang
approved these changes
Nov 7, 2016
| @@ -10,6 +10,7 @@ | |||
| "email": "[email protected]", | |||
| "url": "http://kushagragour.in" | |||
| }, | |||
| "main": "hint.css", | |||
There was a problem hiding this comment.
@th3fallen Can you please move this alongside the similar key: style so that both are together.
|
merged manually. Thanks @th3fallen 👍 @ameech its live :) fixes #149 |
|
Thanks @chinchang! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a main key to package.json for webpack with package splitting