Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use node http base types [BREAKING CHANGE] #730

Merged
merged 1 commit into from
Mar 20, 2022
Merged

refactor: use node http base types [BREAKING CHANGE] #730

merged 1 commit into from
Mar 20, 2022

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Mar 15, 2022 •
edited
Loading

Description

Motivation and Context

See #719

Thanks @devanshj @cdaringe for doing initial work (#478, #721, #723) and help to nudge the types into the correct direction!

How has this been tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

coveralls commented Mar 15, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 98.795% when pulling 03eef2c on node-http-base-types into 0b30c5d on v3.

@chimurai chimurai mentioned this pull request Mar 16, 2022
Closed
5 tasks
@chimurai chimurai force-pushed the node-http-base-types branch 11 times, most recently from e27989b to 15a7e60 Compare March 19, 2022 12:54
@chimurai chimurai added this to the v3.0.0 milestone Mar 19, 2022
@chimurai chimurai changed the title refactor: use node http base types refactor: use node http base types [BREAKING CHANGE] Mar 19, 2022
@chimurai chimurai linked an issue Mar 20, 2022 that may be closed by this pull request
Handler types are incorrectly coupled to express.js #719
Closed
2 tasks
@chimurai chimurai merged commit c8e0f01 into v3 Mar 20, 2022
@chimurai chimurai deleted the node-http-base-types branch March 20, 2022 12:37
This was referenced Mar 20, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Handler types are incorrectly coupled to express.js
2 participants
@chimurai @coveralls