Merge pull request bisq-network#4506 from chimp1984/fix-revolut-accou…

…nt-id-bug Fix revolut accountID bug
chimp1984 · Sep 9, 2020 · 91d70ad · 91d70ad
2 parents a0c298e + 20cb98a
commit 91d70ad
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 7 deletions.
diff --git a/core/src/main/java/bisq/core/payment/PaymentAccount.java b/core/src/main/java/bisq/core/payment/PaymentAccount.java
@@ -173,4 +173,9 @@ public String getSaltAsHex() {
     public String getOwnerId() {
         return paymentAccountPayload.getOwnerId();
     }
+
+    public void onAddToUser() {
+        // We are in the process to get added to the user. This is called just before saving the account and the
+        // last moment we could apply some special handling if needed (e.g. as it happens for Revolut)
+    }
 }
diff --git a/core/src/main/java/bisq/core/payment/RevolutAccount.java b/core/src/main/java/bisq/core/payment/RevolutAccount.java
@@ -37,22 +37,34 @@ protected PaymentAccountPayload createPayload() {
     }
 
     public void setUserName(String userName) {
-        ((RevolutAccountPayload) paymentAccountPayload).setUserName(userName);
+        revolutAccountPayload().setUserName(userName);
     }
 
     public String getUserName() {
-        return ((RevolutAccountPayload) paymentAccountPayload).getUserName();
+        return (revolutAccountPayload()).getUserName();
     }
 
     public String getAccountId() {
-        return ((RevolutAccountPayload) paymentAccountPayload).getAccountId();
+        return (revolutAccountPayload()).getAccountId();
     }
 
     public boolean userNameNotSet() {
-        return ((RevolutAccountPayload) paymentAccountPayload).userNameNotSet();
+        return (revolutAccountPayload()).userNameNotSet();
     }
 
     public boolean hasOldAccountId() {
-        return ((RevolutAccountPayload) paymentAccountPayload).hasOldAccountId();
+        return (revolutAccountPayload()).hasOldAccountId();
+    }
+
+    private RevolutAccountPayload revolutAccountPayload() {
+        return (RevolutAccountPayload) paymentAccountPayload;
+    }
+
+    @Override
+    public void onAddToUser() {
+        super.onAddToUser();
+
+        // At save we apply the userName to accountId in case it is empty for backward compatibility
+        revolutAccountPayload().maybeApplyUserNameToAccountId();
     }
 }
diff --git a/core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java b/core/src/main/java/bisq/core/payment/payload/RevolutAccountPayload.java
@@ -81,7 +81,7 @@ private RevolutAccountPayload(String paymentMethod,
                 excludeFromJsonDataMap);
 
         this.accountId = accountId;
-        setUserName(userName);
+        this.userName = userName;
     }
 
     @Override
@@ -169,7 +169,11 @@ public boolean hasOldAccountId() {
 
     public void setUserName(String userName) {
         this.userName = userName;
-        // We need to set accountId as pre v1.3.8 clients expect the accountId field
+    }
+
+    // In case it is a new account we need to fill the accountId field to support not-updated traders who are not
+    // aware of the new userName field
+    public void maybeApplyUserNameToAccountId() {
         if (accountId.isEmpty()) {
             accountId = userName;
         }

diff --git a/core/src/main/java/bisq/core/user/User.java b/core/src/main/java/bisq/core/user/User.java
@@ -190,6 +190,8 @@ public boolean hasPaymentAccountForCurrency(TradeCurrency tradeCurrency) {
     ///////////////////////////////////////////////////////////////////////////////////////////
 
     public void addPaymentAccount(PaymentAccount paymentAccount) {
+        paymentAccount.onAddToUser();
+
         boolean changed = paymentAccountsAsObservable.add(paymentAccount);
         setCurrentPaymentAccount(paymentAccount);
         if (changed)