Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores generating the hash for custom path if the source is kustomize #13

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

msanterre
Copy link
Contributor

@msanterre msanterre commented Feb 28, 2024

This also ignores the hash generation if the source is Kustomize.

It also cleans up the custom error into a /pkg/kustomize package and makes place for later implementation of this method.

@msanterre msanterre marked this pull request as ready for review February 28, 2024 22:29
@msanterre msanterre requested a review from a team as a code owner February 28, 2024 22:29
@msanterre
Copy link
Contributor Author

@1debit/infrastructure-eng Any idea why the lint is giving me errors for unrelated parts of my PR?

@Nicolas-Richard
Copy link
Collaborator

@1debit/infrastructure-eng Any idea why the lint is giving me errors for unrelated parts of my PR?

Not sure what's going on with the linter, even an empty PR triggers those errors #14

@msanterre msanterre force-pushed the kustomize-ignore-2 branch 3 times, most recently from d4f3f42 to 361d3f6 Compare February 29, 2024 08:31
@msanterre msanterre force-pushed the kustomize-ignore-2 branch 2 times, most recently from 3abfb2f to e00db1d Compare February 29, 2024 20:36
Copy link
Collaborator

@Nicolas-Richard Nicolas-Richard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msanterre msanterre merged commit 6997b7d into main Feb 29, 2024
9 checks passed
@msanterre msanterre deleted the kustomize-ignore-2 branch March 1, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants