Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to pause live graph #18

Closed
aka-Ani opened this issue May 6, 2021 · 3 comments
Closed

Add button to pause live graph #18

aka-Ani opened this issue May 6, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@aka-Ani
Copy link

aka-Ani commented May 6, 2021

First of all, this is a really useful software and a brilliant piece of work!

This is definitely not an "issue" but more of a feature/enhancement. In other serial plotters such as the Arduino built-in, a workaround for pausing the graphing was the disconnect the serial port. This allowed you to take a longer look at the graph or take a screenshot. I suppose the workaround here would be to record to a file and then load that file, but I think a pause/resume toggle for the live graph would be a handy feature.

@chillibasket chillibasket added the enhancement New feature or request label May 6, 2021
@chillibasket chillibasket linked a pull request May 6, 2021 that will close this issue
@chillibasket
Copy link
Owner

chillibasket commented May 6, 2021

Hi, it's great to hear you are putting my software to good use. Your suggestion to add a pause button sounds good and is probably a feature I would see myself using as well. Code contributions are always welcome and I am happy to merge the pull-request into the repo once I have tested the code and am sure it works as expected.

@chillibasket
Copy link
Owner

I have now added this feature in commit 414c8eb. Please try out the latest version of the code in the Master branch and let me know if it is working as expected.

@aka-Ani
Copy link
Author

aka-Ani commented May 11, 2021

I just tried this out, and the pause feature is working great! Thank you for adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants