Skip to content

Commit

Permalink
Fix nasa#62, make entity ID default to 32 bit
Browse files Browse the repository at this point in the history
Entity IDs should be larger by default for real-world applicability, as this also
restricts what CFDP can receive, not just what it sends.  Note CFDP will only use
the number of bytes required to express the value, so values less than 256 will
still only use 1 byte, regardless of this config.  This just allows use of larger
values.
  • Loading branch information
jphickey committed Jan 10, 2022
1 parent b6de205 commit b62f170
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion fsw/platform_inc/cf_platform_cfg.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
** \par Limits
** Must be one of uint8, uint16, uint32, uint64.
*/
typedef uint8 CF_EntityId_t;
typedef uint32 CF_EntityId_t;

/**
** \cfcfg transaction sequence number size
Expand Down
3 changes: 2 additions & 1 deletion fsw/src/cf_msg.h
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ typedef struct CF_TransactionCmd
CFE_MSG_CommandHeader_t cmd_header;
CF_TransactionSeq_t ts;
CF_EntityId_t eid;
uint8 chan; /* if 254, use ts. if 255, all channels */
uint8 chan; /* if 254, use ts. if 255, all channels */
uint8 spare[3]; /* To make structure a multiple of uint32 */
} CF_TransactionCmd_t;

#endif /* !CF_MSG_H */

0 comments on commit b62f170

Please sign in to comment.