Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 一部のコンポーネントを chika3742/mhy-material-components で共通化 #169

Merged
merged 20 commits into from
Sep 5, 2023

Conversation

chika3742
Copy link
Owner

@chika3742 chika3742 commented Sep 5, 2023

chika3742/mhy-material-components

概要

原神素材ノートの開発に向け、UIコンポーネントのみを共通化。ロジックと表示部の実装を分離することで、コードを読みやすくする意図もある。

共通化したUIコンポーネント

  • キャラリストにおけるカードボタン
  • キャラのアイコンのカードボタン
  • キャラ選択プルダウン
  • 素材カード

一部UIの改善も含む。

関係するIssue

#43

chika3742 and others added 19 commits August 31, 2023 22:52
- 詳細ボタンの表示位置を、横並びのアイテムリストの末尾に変更
* feat: キャラ選択プルダウンでの絞り込み

* chore: chika3742/mhy-material-components@a8c9a1c までの取り込み

* fix: 光円錐のキャラを切り替えてもブックマーク状態が変わらない問題
@chika3742 chika3742 linked an issue Sep 5, 2023 that may be closed by this pull request
8 tasks
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e028205
Status: ✅  Deploy successful!
Preview URL: https://de960794.hsr-material.pages.dev
Branch Preview URL: https://43-commonize-components.hsr-material.pages.dev

View logs

@chika3742 chika3742 merged commit b49a30c into main Sep 5, 2023
3 checks passed
@chika3742 chika3742 deleted the 43-commonize-components branch September 5, 2023 08:41
@chika3742 chika3742 restored the 43-commonize-components branch September 5, 2023 08:42
@chika3742 chika3742 deleted the 43-commonize-components branch September 5, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant