Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed final complete callback not firing in angular 1.3 #102

Merged

Conversation

ikrestov
Copy link
Contributor

@ikrestov ikrestov commented Sep 3, 2014

In latest angular 1.3 $animate.leave returns a promise and does not accept a callback anymore.
Changes are backwards compatible with 1.2.

Not sure what to do with tests. After quick glance at karma docs I don't think it is possible to make 2 different file inclusion cases to test against 1.2 and 1.3, so with this change coverage is down to 99.12%.

Kind of depends on #101 or #99 being accepted first, I will update pull request if one of those is accepted.
(relic-@818c673d8feb9ad410e63f98b3a3e35c55fa7a52 has #101 applied)

@chieffancypants
Copy link
Owner

Thanks for the heads up. You don't happen to have a link handy for the breaking changes on $animate do you?

I'm thinking a second karma.conf could be created for angular1.3 and I could just add that as a second task to grunt so it'll run both versions.

Also, #101 was merged, so feel free to make any updates if you need to.

@chieffancypants chieffancypants merged commit e77dad7 into chieffancypants:master Sep 4, 2014
@chieffancypants chieffancypants added this to the next version milestone Sep 4, 2014
@ikrestov ikrestov deleted the fix-angular1.3-animate branch September 10, 2014 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants