Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of a bug related to logs + improvement of gitignore generation #36

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Conversation

AdrasteonDev
Copy link
Contributor

@AdrasteonDev AdrasteonDev commented Nov 18, 2023

First of all, thank you for creating GodotEnv ! I've been looking for a dotnet-based package manager for Godot for a while.

I encountered two minor problems during my initial tests.

I had a problem with the color of the terminal text after calling certain commands (on Windows CMD):

Capture d'écran 2023-11-16 072920
Capture d'écran 2023-03-07 192426b

I also noticed that the .addons folder and the files that should be ignored with Godot (https://github.com/github/gitignore/blob/main/Godot.gitignore) were not automatically added to the gitignore.

I created this PR to solve these two minor problems. I've allowed changes in the forked repo, so feel free to edit my changes if you want.

@jolexxa
Copy link
Member

jolexxa commented Nov 19, 2023

Thank you, this is great! <3

@jolexxa jolexxa merged commit e7dc85b into chickensoft-games:main Nov 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants