Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up equal() / less_equal() #186

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Clean up equal() / less_equal() #186

merged 2 commits into from
Sep 30, 2021

Conversation

chfast
Copy link
Owner

@chfast chfast commented Sep 30, 2021

No description provided.

Do not you memcmp() for is_equal() implementation. This is the only
place where memcmp() is used. Instead implement it as 4 word comparison.
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #186 (bf4ddd5) into master (5ef7e05) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1652      1653    +1     
=========================================
+ Hits          1652      1653    +1     
Flag Coverage Δ
be 89.54% <100.00%> (+<0.01%) ⬆️
default 99.81% <100.00%> (+<0.01%) ⬆️
x86_64 89.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ethash/ethash-internal.hpp 100.00% <100.00%> (ø)
lib/ethash/ethash.cpp 100.00% <100.00%> (ø)
lib/ethash/progpow.cpp 100.00% <100.00%> (ø)
test/unittests/test_ethash.cpp 100.00% <100.00%> (ø)

@chfast chfast merged commit 54f425a into master Sep 30, 2021
@chfast chfast deleted the memcmp_cleanup branch September 30, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants