Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBM J9 parser #240

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

cmoetzing
Copy link

@cmoetzing cmoetzing commented Jan 23, 2020

Scavenge collects were incorrectly marked as full gc.
Concurrent collects resulted in a parse error.
Tenured heap was displayed incorrectly due to missing timestamp.

Christian Mötzing added 2 commits January 23, 2020 14:14
The tag concurrent-collection-start marks a full gc pase.
@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #240 into develop will increase coverage by 0.04%.
The diff coverage is 92.3%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #240      +/-   ##
=============================================
+ Coverage      70.49%   70.53%   +0.04%     
- Complexity      1522     1528       +6     
=============================================
  Files            146      146              
  Lines           8632     8641       +9     
  Branches        1392     1396       +4     
=============================================
+ Hits            6085     6095      +10     
+ Misses          1963     1961       -2     
- Partials         584      585       +1
Impacted Files Coverage Δ Complexity Δ
...er/view/renderer/ConcurrentGcBeginEndRenderer.java 40.74% <ø> (ø) 3 <0> (?)
...um/perf/gcviewer/ctrl/impl/GCViewerGuiBuilder.java 94.76% <100%> (ø) 6 <0> (ø) ⬇️
...om/tagtraum/perf/gcviewer/view/ModelChartImpl.java 79.73% <100%> (ø) 38 <0> (ø) ⬇️
.../tagtraum/perf/gcviewer/model/AbstractGCEvent.java 86.47% <88.23%> (+0.3%) 76 <7> (+2) ⬆️
...gtraum/perf/gcviewer/imp/DataReaderIBM_J9_R28.java 84.66% <95%> (+0.86%) 51 <2> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1075435...7c4c044. Read the comment docs.

Christian Mötzing added 3 commits January 23, 2020 17:09
Scavenge operation only affects young gen.
See description of tag '<gc-start>' attribute 'type' value 'scavenge' at
https://www.ibm.com/support/knowledgecenter/SSYKE2_8.0.0/com.ibm.java.vm.80.doc/docs/mm_gc_pd_verbose_increment.html
Due to wrong timestamps the last size of tenured space was used
as value for the whole graph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants