Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Re-enable --testmon once the coverage issue is fixed #71

Closed
webknjaz opened this issue Jan 7, 2018 · 3 comments
Closed

[TODO] Re-enable --testmon once the coverage issue is fixed #71

webknjaz opened this issue Jan 7, 2018 · 3 comments

Comments

@webknjaz
Copy link
Member

webknjaz commented Jan 7, 2018 •
edited
Loading

Because of tarpas/pytest-testmon#86 --testmon corrupts coverage data, so I'm dropping it from pytest.ini (8a161e8). This should be reverted once upstream issue fixed.

TODO: git revert 8a161e87
webknjaz added a commit that referenced this issue Jan 7, 2018
@webknjaz
Revert "Revert "Use testmon in watch toxenv only""
8a161e8 
This reverts commit de0de59.

Ref tarpas/pytest-testmon#86
Ref #71
@stale
Copy link

stale bot commented Mar 8, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This thing has been ignored for too long label Mar 8, 2018
@stale stale bot closed this as completed Mar 15, 2018
@webknjaz
Copy link
Member Author

Unstale. Looks like tarpas/pytest-testmon#86 is still in progress.

@webknjaz webknjaz reopened this Mar 15, 2018
@stale stale bot removed the stale This thing has been ignored for too long label Mar 15, 2018
@webknjaz
Copy link
Member Author

webknjaz commented Apr 21, 2018 •
edited
Loading

According to tarpas/pytest-testmon#86 pytest-cov conflicts with pytest-testmon, because coverage.py also relies on sys.settrace (tarpas/pytest-testmon#97). Ref: https://coverage.readthedocs.io/en/coverage-4.5.1/trouble.html#things-that-don-t-work.

webknjaz added a commit that referenced this issue Apr 21, 2018
@webknjaz
Revert "Revert 8a161e8 and fix #71 with a workaround"
3046067 
This reverts commit 26eea5c.
webknjaz added a commit that referenced this issue Apr 21, 2018
@webknjaz
Revert "Revert "Revert 8a161e8 and fix #71 with a workaround""
02e4404 
This reverts commit 3046067.

Use --testmon-off instead of -p no:testmon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@webknjaz