Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow boot image autodetection to inspect boot images #237

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

chenxiaolong
Copy link
Owner

During patching, all boot images are now extracted and the individual patchers can inspect them to determine which ones need modifications. This replaces the previous mechanism of detecting which boot images to patch based on the name alone.

With this new method, the --boot-partition and --otacerts-partitions options are no longer needed. The former option is kept (but ignored with a warning message) for backwards compatibility, but the latter is completely removed because it never made it to a stable release.

During patching, all boot images are now extracted and the individual
patchers can inspect them to determine which ones need modifications.
This replaces the previous mechanism of detecting which boot images to
patch based on the name alone.

With this new method, the --boot-partition and --otacerts-partitions
options are no longer needed. The former option is kept (but ignored
with a warning message) for backwards compatibility, but the latter is
completely removed because it never made it to a stable release.

Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong self-assigned this Dec 22, 2023
@chenxiaolong
Copy link
Owner Author

This also fixes a subtle bug where if the user passed in --replace vbmeta_<something> <path> and the vbmeta_<something> did not require patching, then it was silently ignored.

@chenxiaolong chenxiaolong merged commit 0944abc into master Dec 22, 2023
26 checks passed
@chenxiaolong chenxiaolong deleted the autodetect branch December 22, 2023 21:14
chenxiaolong added a commit that referenced this pull request Dec 22, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant