avb: Add support for AVB 2.0 format 1.3.0 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this new format version, I guess "AVB 2.0" no longer refers to just one thing. I wish they made the AVB version and the file format version the same. Otherwise, we'll end up with things like "USB 3.2 Gen 2x2" 🙂 |
Format version 1.3.0 adds a new 32-bit big endian `flags` field to chain descriptors, carved out from the `reserved` array. There is only one possible flag, which indicates that the target partition is not A/B and so the bootloader should not append the `_a` or `_b` suffix. There are no known AVB images in the wild where the first four bytes of the `reserved` field are not zero. Thus, to keep the logic simple, the AVB parser will unconditionally parse those bytes as if they were the `flags` field, regardless of the file format version. AOSP changes: * https://android.googlesource.com/platform/external/avb/+/a1fe228b86543a21739c51352f5ce72f134fccfa%5E%21/ * https://android.googlesource.com/platform/external/avb/+/d00d02c390e267ef43d93562864dd6e45966c435%5E%21/ Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
avb_2.0_format_1.3
branch
from
83e82c2
to
a648df1
Compare
chenxiaolong
added a commit
that referenced
this pull request
Nov 23, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format version 1.3.0 adds a new 32-bit big endian
flagsfield to chain descriptors, carved out from thereservedarray. There is only one possible flag, which indicates that the target partition is not A/B and so the bootloader should not append the_aor_bsuffix.There are no known AVB images in the wild where the first four bytes of the
reservedfield are not zero. Thus, to keep the logic simple, the AVB parser will unconditionally parse those bytes as if they were theflagsfield, regardless of the file format version.AOSP changes: