cpio: Only reassign inodes when missing #178
Merged
+85
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, archives with hard links can pass through `cpio unpack` and `cpio pack`, even though there's no explicit support for hard links. This also changes the trailer entry logic to not set an inode number. AOSP's mkbootfs and magiskboot both start at 300000 and increment by one for each entry, including the trailer. However, GNU cpio, bsdcpio, busybox, and toybox all set it to 0, which makes more sense given that it doesn't represent anything on disk. Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
added a commit
that referenced
this pull request
Oct 1, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, archives with hard links can pass through
cpio unpackandcpio pack, even though there's no explicit support for hard links.This also changes the trailer entry logic to not set an inode number. AOSP's mkbootfs and magiskboot both start at 300000 and increment by one for each entry, including the trailer. However, GNU cpio, bsdcpio, busybox, and toybox all set it to 0, which makes more sense given that it doesn't represent anything on disk.