-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it not work with vendor_boot?? #218
Comments
@chenxiaolong Please help me check it!!! |
Huh, the OTA file you linked puts I'll need to think about how to solve this. avbroot's current logic won't work. |
Going by the filename and installed apps in the ROM the device in question is a Viettel TV360. These devices seem to be used by a local TV provider in Vietnam only and as such it's very hard to find any information in english about it. Is there even reason to believe they support the required custom root of trust ( |
That's a really good point. If custom root of trust isn't supported, I probably won't add support for this OTA's weird setup for now. @chautruongthinh Please try |
It worked!! |
Yes!! It is Amlogic S905Y4 Android TV BOX (Viettel TV360 IP151N). It's lock every things but i found the way to unlock bootloader and i can flash custom firmware with fastboot and disable verification vbmeta. |
Although I'm a little confused about this statement; sunfish (Pixel 4a) has neither |
Maybe avbroot extract boot.img first and found |
Whoops, you're right, I forgot about that. The way it works right now is that it looks for the first partition that exists in this list: avbroot/avbroot/src/cli/ota.rs Line 58 in 02fd92a
Because this OTA contains For now, I think I'll just add a new option, like |
AOSP primarily cares about `odm` and `odm_dlkm`, so update the logic to check for that specifically. This fixes patching some OTAs that include an unprotected OEM-specific `odm_ext` image. Issue: #218 Signed-off-by: Andrew Gunnerson <[email protected]>
The autodetection logic for `@otacerts` is based on the presence of the `recovery`, `vendor_boot`, and `boot` partitions (in that order). Some devices have `vendor_boot`, but put `system/etc/security/otacerts.zip` inside `boot`. With the way things are written now, we don't have the ability to inspect the actual partition images for the autodetection. It is based on the name only. So, for now, we'll just allow the user to override the autodetected partition similar to what we already do with the `--boot-partition` option. Issue: #218 Signed-off-by: Andrew Gunnerson <[email protected]>
The autodetection logic for `@otacerts` is based on the presence of the `recovery`, `vendor_boot`, and `boot` partitions (in that order). Some devices have `vendor_boot`, but put `system/etc/security/otacerts.zip` inside `boot`. With the way things are written now, we don't have the ability to inspect the actual partition images for the autodetection. It is based on the name only. So, for now, we'll just allow the user to override the autodetected partition similar to what we already do with the `--boot-partition` option. Issue: #218 Signed-off-by: Andrew Gunnerson <[email protected]>
Please give #221 a try. A test build is available at the bottom of: https://github.com/chenxiaolong/avbroot/actions/runs/7160297544?pr=221 When running the |
Yeah!! Thanks your support, it's worked fine But i cant verify it |
The autodetection logic for `@otacerts` is based on the presence of the `recovery`, `vendor_boot`, and `boot` partitions (in that order). Some devices have `vendor_boot`, but put `system/etc/security/otacerts.zip` inside `boot`. With the way things are written now, we don't have the ability to inspect the actual partition images for the autodetection. It is based on the name only. So, for now, we'll just allow the user to override the autodetected partition similar to what we already do with the `--boot-partition` option. Issue: #218 Signed-off-by: Andrew Gunnerson <[email protected]>
Ah oops. I need to add the I've just updated #221. A new test build will be available at https://github.com/chenxiaolong/avbroot/actions/runs/7162948144?pr=221 once the build completes in a few minutes. |
It's worked fine |
Great! I will merge #221 then. That change will be included in the next version of avbroot. |
I tried repach my OTA zip and get some errors!!
avbroot.exe ota patch --input IP151_ota120623.zip --key-avb avb.key --key-ota ota.key --cert-ota ota.crt --rootless
←[1m[] Replacing zip entry: META-INF/com/android/otacert←[0m
←[1m[] Copying zip entry: care_map.pb←[0m
←[1m[] Patching zip entry: payload.bin←[0m
←[1m[] Extracting from original payload: vbmeta←[0m
←[1m[] Extracting from original payload: vendor_boot←[0m
←[1m[] Extracting from original payload: vbmeta_system←[0m
←[1m[*] Patching boot images: vendor_boot←[0m
Error: Failed to patch OTA zip
Caused by:
0: Failed to patch payload: payload.bin
1: Failed to patch boot image: vendor_boot
2: Validation error: No ramdisk contains "system/etc/security/otacerts.zip"
The text was updated successfully, but these errors were encountered: