Add support for using contact groups in record rules #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenxiaolong
force-pushed
the
contact-group
branch
2 times, most recently
from
efd4caa
to
575d29f
Compare
This is unfortunately a relatively big change because unlike single contacts, Android does not provide a standard intent for apps to select a contact group. We have to implement our own contact group picker UI. Following our current convention, the most specific rule wins as a side effect of how rules are sorted. If a call matches both a contact and a contact group, the contact rule has higher precedence. Fixes: #536 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
contact-group
branch
from
575d29f
to
48cb283
Compare
chenxiaolong
added a commit
that referenced
this pull request
Sep 22, 2024
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unfortunately a relatively big change because unlike single contacts, Android does not provide a standard intent for apps to select a contact group. We have to implement our own contact group picker UI.
Following our current convention, the most specific rule wins as a side effect of how rules are sorted. If a call matches both a contact and a contact group, the contact rule has higher precedence.
Fixes: #536