Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hindi translation strings.xml #459

Merged
merged 4 commits into from
Nov 19, 2023
Merged

Conversation

y0geshx
Copy link
Contributor

@y0geshx y0geshx commented Nov 16, 2023

added hindi translation strings.xml

@chenxiaolong
Copy link
Owner

Thanks for the PR! Please also add hi to:

<locale-config xmlns:android="http://schemas.android.com/apk/res/android">
<locale android:name="de" />
<locale android:name="en" />
<locale android:name="es" />
<locale android:name="fr" />
<locale android:name="iw" />
<locale android:name="pl" />
<locale android:name="ru" />
<locale android:name="sk" />
<locale android:name="tr" />
<locale android:name="uk" />
<locale android:name="zh-rCN" />
<locale android:name="zh-rTW" />
</locale-config>

and

BCR/app/build.gradle.kts

Lines 121 to 134 in 8ea0ec0

resourceConfigurations.addAll(listOf(
"de",
"en",
"es",
"fr",
"iw",
"pl",
"ru",
"sk",
"tr",
"uk",
"zh-rCN",
"zh-rTW",
))

These are needed for Android 13's per-app language feature to work.

@chenxiaolong chenxiaolong self-assigned this Nov 16, 2023
@y0geshx
Copy link
Contributor Author

y0geshx commented Nov 17, 2023

Will add 👍

@y0geshx
Copy link
Contributor Author

y0geshx commented Nov 17, 2023

added hi in locales_config.xml and build.gradle.kts

@chenxiaolong chenxiaolong merged commit d15450c into chenxiaolong:master Nov 19, 2023
1 check passed
chenxiaolong added a commit that referenced this pull request Nov 19, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants