Replace format parameter slider with chips #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a slider with a min, max, and step size, the format parameter is configured using chips. For each format, there are three presets and there's an additional option for the user to set a specific compression level or bitrate. The user's existing settings will be preserved. Fixes: #295 Signed-off-by: Andrew Gunnerson <[email protected]>
Signed-off-by: Andrew Gunnerson <[email protected]>
The dialog happens to restore the last user input state after the setText() call, but it's not documented to do that, so avoid relying on that behavior. Signed-off-by: Andrew Gunnerson <[email protected]>
This commit replaces the file retention slider with a simple dialog for entering a custom value. Unlike the output format parameters, this setting is purely a personal preference and there's no reason to suggest hardcoded durations. This was the last component that still used the Material 3 slider. No more janky animations and abusing floating point values. Signed-off-by: Andrew Gunnerson <[email protected]>
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a slider with a min, max, and step size, the format parameter is configured using chips. For each format, there are three presets and there's an additional option for the user to set a specific compression level or bitrate. The user's existing settings will be preserved.
Fixes: #295