RecorderThread: Write duration to FLAC STREAMINFO metadata block #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaCodec's FLAC encoder does not write the final duration to the STREAMINFO metadata block. The streaming nature of the API makes that impossible. Instead, when the recording completes, BCR will find the STREAMINFO block and update the total frame count field manually. This fixes seeking in audio players that don't try to guess the length of the audio file. Fixes: #19 Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaCodec's FLAC encoder does not write the final duration to the
STREAMINFO metadata block. The streaming nature of the API makes that
impossible. Instead, when the recording completes, BCR will find the
STREAMINFO block and update the total frame count field manually.
This fixes seeking in audio players that don't try to guess the length
of the audio file.
Fixes: #19