RecorderThread: Use non-blocking reads from AudioRecord #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Samsung devices, when a call ends, AudioRecord.read() blocks until another call becomes active, which prevents recordings from stopping at the correct time. This behavior does not happen in AOSP. To work around this, use non-blocking reads with a sleep interval of the AudioRecord minimum buffer size. This gives the recording loop a chance to check if recording has been cancelled. Issue: #143 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
non-blocking
branch
from
17fa150
to
5b019f1
Compare
chenxiaolong
added a commit
that referenced
this pull request
Oct 9, 2022
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Samsung devices, when a call ends,
AudioRecord.read()blocks until another call becomes active, which prevents recordings from stopping at the correct time. This behavior does not happen in AOSP.To work around this, use non-blocking reads with a sleep interval of the
AudioRecordminimum buffer size. This gives the recording loop a chance to check if recording has been cancelled.Issue: #143