-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to record call #507
Comments
If you change the sample rate to 48000 Hz, does it still fail? EDIT: If you wouldn't mind, could you please install https://play.google.com/store/apps/details?id=com.parseus.codecinfo, find the |
Oh my god how silly of me, I dont know since when did it change to 16000, used to be 48000 since 1.40, somehow updating from 1.59 to 1.60 changed the sample rate to 16000. Everything works normally now on 48000. Thank you and sorry for wasting some of your time. |
It's not a waste of my time at all :) 1.60 changed the default from 48000 Hz to 16000 Hz. During the update, if you never changed the sample rate in the past, then BCR would use the new default value. It seems that your device doesn't support 16000 Hz for some reason. (If you wouldn't mind posting some additional details, it might help with understanding why--please see my previous edited comment.) Since 16000 Hz is clearly problematic, I will revert the change and set the default back to 48000 Hz in version 1.62. |
I'm not sure what kind of additional details I can give, if you mean my device, it's Redmi K20 Pro (raphael) |
Thanks! Sorry, by "additional details", I only meant the codec info |
Thanks! That confirms it then. The device only supports 48000 Hz. That's incredibly weird though. |
This is a Redmi series, more like a flagship killer tier so mostly some of the higher end features will be cutoff to reduce the cost and the selling price. |
Some devices unfortunately disable common sample rates that are normally supported in AOSP's software encoders. This commit reworks all of BCR's MediaCodec-based formats to query for the list of supported sample rates instead of relying on a hardcoded list. If BCR's default sample rate for a format is not supported, the closest supported sample rate will be used. The same applies for Android upgrades that remove support for the sample rate previously chosen by the user. These queries are fast enough to be unnoticeable on Pixel devices. Hopefully other OEMs don't make modifications that slow this down, like they do for so many other things. Fixes: #507 Signed-off-by: Andrew Gunnerson <[email protected]>
This will be fixed by #508, which changes BCR's behavior so that only the sample rates supported by the device are listed. This will be included in the next version of BCR (version 1.62). |
Some devices unfortunately disable common sample rates that are normally supported in AOSP's software encoders. This commit reworks all of BCR's MediaCodec-based formats to query for the list of supported sample rates instead of relying on a hardcoded list. If BCR's default sample rate for a format is not supported, the closest supported sample rate will be used. The same applies for Android upgrades that remove support for the sample rate previously chosen by the user. These queries are fast enough to be unnoticeable on Pixel devices. Hopefully other OEMs don't make modifications that slow this down, like they do for so many other things. Fixes: #507 Signed-off-by: Andrew Gunnerson <[email protected]>
Some devices unfortunately disable common sample rates that are normally supported in AOSP's software encoders. This commit reworks all of BCR's MediaCodec-based formats to query for the list of supported sample rates instead of relying on a hardcoded list. If BCR's default sample rate for a format is not supported, the closest supported sample rate will be used. The same applies for Android upgrades that remove support for the sample rate previously chosen by the user. These queries are fast enough to be unnoticeable on Pixel devices. Hopefully other OEMs don't make modifications that slow this down, like they do for so many other things. Fixes: #507 Signed-off-by: Andrew Gunnerson <[email protected]>
I've been having this issue on 1.60 only. Same setup as shown in screenshot till 1.59, same ROM, no issue recording. Hope you can look into this. Thank you.
The text was updated successfully, but these errors were encountered: