-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Phone app labels outgoing calls to businesses with the business name; can BCR do the same? #291
Comments
This is unfortunately the case. The online lookup process is done entirely within Google Dialer and it doesn't provide that information back to the telephony framework or anywhere else. |
It seems that's not entirely true. I downloaded another dialer, and after granting call log access, I'm seeing the same business names Google Phone identified that shouldn't otherwise be there. If the call log can be queried by number (or iterated through until you find a match), that's the path forward should you choose to follow it. I feel like significantly improving filename discovery is a worthwhile pursuit, but would also respect KISS if cited. |
Hmm, I didn't think to go at it via the call log API. I'm not very familiar with it, but I wonder if it allows dialer apps to put whatever information they want in it. I'll investigate. Which third party dialer did you use for testing? |
Simple Dialer does the trick. |
Thanks! Looks like I'm going to finish tackling #288 before coming back to this. If the call log is updated by the time the call reaches the |
Do you happen to have a test number that I can try calling to trigger Google Dialer's business lookup feature? (I can call numbers in the US or Canada. EDIT: Oops, turns out my plan does not allow calling Canada numbers.) I've tried calling a few random ISP's customer service numbers and even if they trigger the fancy Google Assistant speech recognition thing, the call log only shows the phone number. |
Anything you can look up in Google Maps should work. Here's one that just worked for me: 204-269-6548. Note that you need to have the associated option enabled in Phone. |
Oh, just saw your edit. I can't call US numbers to confirm, so, Google Maps it is. |
Thanks! Any chance you know what the option is? I looked through my call history for something with a business name, called it again, and the new call log entry only has a phone number. |
Settings > Caller ID & spam > See caller and spam ID |
Hmm, I already have that enabled. Doesn't seem to work on VoWIFI or cellular. |
Bizarre. I just turned it off, tried another grocery store, and it didn't identify it. |
Gah, Google must've pushed out a bad update or something. I uninstalled Google Dialer updates and it's working. Installed the update again and it broke. EDOT: Broken version for me is |
Well anyway, I have enough logs from a few test calls with the old Google Dialer. It looks like Google Dialer takes anywhere from 100ms to 1200ms to update the call log after the call enters the I'm going to make BCR poll every 100ms for up to 2s after the call completes to get the call log name, but only if |
This commit adds a new `{call_log_name}` variable that can be used in the filename template for including the call log cached name. The cache name may be updated by the system dialer to include the name of the business assocciated with the phone number. This new variable is added to the default filename template, but only as a last resort because it relies on polling for up to 2 seconds after the call completes. Fixes: #291 Signed-off-by: Andrew Gunnerson <[email protected]>
This commit adds a new `{call_log_name}` variable that can be used in the filename template for including the call log cached name. The cache name may be updated by the system dialer to include the name of the business assocciated with the phone number. This new variable is added to the default filename template, but only as a last resort because it relies on polling for up to 2 seconds after the call completes. Fixes: #291 Signed-off-by: Andrew Gunnerson <[email protected]>
Beautiful. This next release is gonna be lit. |
To my surprise and delight, every single business number I've manually dialed since moving from VoIP to a cell plan has been correctly identified and labelled by Google Phone in my call logs. Is there a way to obtain this information through the telephony framework and apply it to
${caller_name}
when empty, or is this a Phone-exclusive feature with no retrieval interface?The text was updated successfully, but these errors were encountered: