Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plus from phone number #290

Closed
Daeamon opened this issue Apr 13, 2023 · 1 comment · Fixed by #299
Closed

Remove plus from phone number #290

Daeamon opened this issue Apr 13, 2023 · 1 comment · Fixed by #299
Assignees
@chenxiaolong
Labels
enhancement New feature or request

Comments

@Daeamon
Copy link

Daeamon commented Apr 13, 2023

Hello, if filename contains plus symbol as in phone number +79999999999 then i couldn't sync this file to my cloud.
Can you add format feature to phone numbers too?
@chenxiaolong chenxiaolong self-assigned this Apr 18, 2023
@chenxiaolong chenxiaolong added the enhancement New feature or request label Apr 18, 2023
chenxiaolong added a commit that referenced this issue Apr 18, 2023
@chenxiaolong
Add support for some phone number formatting options
0384d8a 
The two new added options are `digits_only` and `formatted`
(country-specific style). These are the only two options that can be
feasibly supported without pulling in something like libphonenumber.

Fixes: #290

Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong mentioned this issue Apr 18, 2023
Merged
@chenxiaolong
Copy link
Owner

The next BCR release (version 1.40) will officially support custom filename templates. You'll be able to edit the template and change {phone_number} to {phone_number:digits_only} to get this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for some phone number formatting options chenxiaolong/BCR
2 participants
@chenxiaolong @Daeamon