Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't record when number withheld #111

Closed
Derkish opened this issue Aug 3, 2022 · 6 comments · Fixed by #114
Closed

Doesn't record when number withheld #111

Derkish opened this issue Aug 3, 2022 · 6 comments · Fixed by #114
Assignees
Labels
bug Bug in BCR itself

Comments

@Derkish
Copy link

Derkish commented Aug 3, 2022

If the recipient withholds their phone number (also known as private number), the app won't record the incoming phone call. Apart from that, your app is perfect.

I'm unsure about other countries, but in Britain you can test this (withhold your phone number) by prefixing 141 before the dialing mobile number that bcr is installed on.

@chenxiaolong chenxiaolong self-assigned this Aug 4, 2022
@chenxiaolong chenxiaolong added the bug Bug in BCR itself label Aug 4, 2022
@chenxiaolong
Copy link
Owner

Hmm, I'm not sure how to test this in the US. I don't think we have anything like the 141 prefix you mentioned (which seems pretty neat).

Could you enable debug mode (long press the version number in BCR) and then attempt to record a call from a private number? It should hopefully create a log file in the output folder. If not (because the recording isn't getting triggered), you may have to attempt to record 2 calls for it to create the log file: first from a private number and the second from a non-private number.

@effectively0
Copy link

I'm fairly sure you can do a similar thing in the USA. It's just CallerID https://smallbusiness.chron.com/edit-caller-id-android-28530.html

@Derkish
Copy link
Author

Derkish commented Aug 4, 2022

I uninstalled bcr due to it not recording incoming phone calls when caller ID is withheld (I'm now using another app which isn't free but fits my needs), but apart from that bug, your app is excellent.

Yeah effectively0 is right, that looks the equivalent thing in America.
https://www.geeky-gadgets.com/how-to-hide-your-number-on-an-android-phone-30-06-2022/

According to the article, you can also withhold number on Android phones by going, Phone > Settings > Calls >Additional Settings > Caller ID > Hide my number

So changing Caller ID to hidden and then phoning a second phone that has bcr installed is a way to test it.

@chenxiaolong
Copy link
Owner

chenxiaolong commented Aug 4, 2022

Thanks! I was not aware the US had a prefix too (*67).

Looks like there are two issues:

  • the method BCR uses to grab the phone number (for the filename) is crashing
  • the crash doesn't get reported to the user so it looks like nothing is happening

I'll fix these and likely release a new version tonight.

@chenxiaolong
Copy link
Owner

This is fixed in #114 and will be part of version 1.17.

@chenxiaolong
Copy link
Owner

Version 1.17 has been released.

chenxiaolong added a commit that referenced this issue Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in BCR itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants