Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to support webpack for kibana5 #6

Closed
chenryn opened this issue May 6, 2016 · 1 comment
Closed

need to support webpack for kibana5 #6

chenryn opened this issue May 6, 2016 · 1 comment

Comments

@chenryn
Copy link
Owner

chenryn commented May 6, 2016

Try to run this vis on kibana5, then got a TypeError: _d32.default.sankey is not a function.
If I change the _d32["default"].sankey in kibana.bundle.js as d3.sankey, all can run right.
But I didn't know how the webpack compile d3.sankey() into _d32["default"].sankey().
@chenryn chenryn mentioned this issue Jun 2, 2016
Closed
@chenryn chenryn mentioned this issue Jun 10, 2016
Closed
chenryn added a commit that referenced this issue Jun 10, 2016
@chenryn
first commit to support kibana5, has a bug now.
55aae65 
#6
@chenryn
Copy link
Owner Author

chenryn commented Dec 22, 2016

image

dispatch the d3-sankey js file within this plugin now....

@chenryn chenryn closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chenryn