-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not working with 5.5 #18
Comments
Just committed a working version for Kibana 5.5 on my https://github.com/JuanCarniglia/kbn_sankey_vis, check the releases folder. Regards |
@JuanCarniglia - I'm trying to install your build. However, i hit upon an error stating that there is no gulp file when I run |
I think you would be better just copying the files on a "kbn_sankey_vis" folder in the "src/core_plugins" folder, and rebundling. I haven't been able to get the install scripts working just yet, maybe next week. Sorry. Regards |
Thank for the reply @JuanCarniglia but I'm not getting what you're trying to say. Forgive me since I'm a bit new to the whole ELK environment and am still figuring out certain things. I did the following:
I got the below error and kibana fails to start up:
I took a look at the other core plugin's FROM:
TO:
After doing the above change, kibana starts up fine, but the visualization is missing. What am I missing?Appreciate the help. Thanks. |
Sure.
So, from the start. Kibana is a node/angular app. When you run it, it uses
a module called webpack to bundle up all the files that make up the
application (js, html, css). This is as to have just a single (or a couple
of) big javascript files that the browser can download just one time, and
cache them. From then on, all that comes and goes between server and
client, is just data, not application files.
So, when you introduce a new element in that javascript/html ecosystem (or
you update a file), you have to re-bundle the whole thing.
One way to do this is simply by removing the current bundle files (in this
case called kibana.* in optimize/bundles/) and restarting Kibana.
(You SHOULD back these files up before removing them).
This is what I call re-bundling.
About the plugin, for it to work, you can copy the source files into
src/plugins/kbn_sankey_vis (for kibana 4.x) or
src/core_plugins/kbn_sankey_vis (for kibana 5.x or 6.x).
There is a way to install the plugin using an utility provided by Elastic
(which is in the bin folder) but I haven't gotten around to pack my plugins
to be used like that. This utility installs the plugins in another folder.
I hope it's clearer now.
Do not hesitate to ask me any other questions you might have.
Thanks
2017-09-25 3:39 GMT-03:00 Bharath <[email protected]>:
… Thank for the reply @JuanCarniglia <https://github.com/juancarniglia> but
I'm not getting what you're trying to say. Forgive me since I'm a bit new
to the whole ELK environment and am still figuring out certain things.
Would you please tell me what files I need to copy? By src/core_plugins,
do you mean kibana's plugin directory? (/usr/share/kibana/plugins/)
Re-bundling also is something I'm not aware of. Could you please elaborate
a bit more?
Appreciate the help. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOi0O_BRwtD6zQFtu4D-oBX3bFbcnrQSks5sl0q-gaJpZM4PEHP4>
.
--
Juan Ignacio Carniglia
|
@JuanCarniglia - Thanks for the explanation, It made a lot of sense! I had earlier tried something similar and ended up with errors. The only part I had skipped was removing the bundles. I tried the same after going through your post. I see the same error repeating. If I modify the index.js to make the error go away, I don't see the visualization showing up. |
Ok, there is now a newer version in the releases/5.5 folder. Please try it. |
I have problemes installing it:
Also i had to edit package.json, since it complained about a "invalid version" could you please add additional install instructions? |
Oh sorry i missed post no.3... so i followed all your instructions. I had to
|
Seems that you have a different D3 version or something... let me get back
to you.
|
I did as belows.
(plugins folder is empty) But, i can't see any sankey-diagram with below error,
As your comment, this error is caused by version problem. Thank you. |
On Kibana 5.5.0 to run this plugin I did:
'use strict'; Object.defineProperty(exports, '__esModule', { exports['default'] = function (kibana) { return new kibana.Plugin({
}); module.exports = exports['default']; (U can see this is how it should be done by viewing other core plugins)
var sankeyFactory = function() { sankey.nodeWidth = function() { sankey.nodePadding = function() { sankey.nodes = function(_) { sankey.links = function(_) { sankey.size = function(_) { sankey.layout = function(iterations) { sankey.relayout = function() { sankey.link = function() {
} // Populate the sourceLinks and targetLinks for each node. // Compute the value (size) of each node by summing the associated links. // Iteratively assign the breadth (x-position) for each node.
} function moveSourcesRight() { function moveSinksRight(x) { function scaleNodeBreadths(kx) { function computeNodeDepths(iterations) {
} function computeLinkDepths() {
} function center(node) { function value(link) { return sankey And last thing I changed changed the code in 'module.controller('KbnSankeyVisController', function ($scope, $element, $rootScope, Private)' to 'let sankey = sankeyFactory() Hope this helps! |
not working with 5.5
The text was updated successfully, but these errors were encountered: