fix(ApkParser): versionName special chars filter

#61
chenquincy · Jun 15, 2021 · de6db75 · de6db75
1 parent ef91d41
commit de6db75
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/dist/app-info-parser.js b/dist/app-info-parser.js
@@ -1641,6 +1641,11 @@ var BinaryXmlParser = /*#__PURE__*/function () {
       attr.nodeName = attr.name = this.strings[nameRef];
 
       if (valueRef > 0) {
+        // some apk have versionName with special characters
+        if (attr.name === 'versionName') {
+          this.strings[valueRef] = this.strings[valueRef].replace(/[^\d\w-.]/g, '');
+        }
+
         attr.value = this.strings[valueRef];
       }
 

diff --git a/dist/app-info-parser.js.map b/dist/app-info-parser.js.map
diff --git a/dist/app-info-parser.min.js b/dist/app-info-parser.min.js
diff --git a/dist/app-info-parser.min.js.map b/dist/app-info-parser.min.js.map
diff --git a/lib/xml-parser/binary.js b/lib/xml-parser/binary.js
@@ -543,6 +543,10 @@ and is supposed to end at offset ${end}. Ignoring the rest of the value.`)
     attr.nodeName = attr.name = this.strings[nameRef]
 
     if (valueRef > 0) {
+      // some apk have versionName with special characters
+      if (attr.name === 'versionName') {
+        this.strings[valueRef] = this.strings[valueRef].replace(/[^\d\w-.]/g, '')
+      }
       attr.value = this.strings[valueRef]
     }