sql: return droppedView instead of nil

In cockroachdb#97631 we refactor the method to drorp index and column cascade dependents. But we didn't return a correct droppedViews, instead, we returned a nil. This wasn't caught by the `event_log` logic test because we skip `local-legacy-schema-changer` test config in v23.1. Luckily,this was caught when backporting to v22.2 because there was a fallback. Epic: None Release note: None
chengxiong-ruan · Feb 28, 2023 · d027c9c · d027c9c
1 parent 3ed2c8f
commit d027c9c
Show file tree

Hide file tree

Showing 4 changed files with 1,127 additions and 2 deletions.
diff --git a/pkg/sql/drop_index.go b/pkg/sql/drop_index.go
@@ -555,5 +555,5 @@ func (p *planner) removeDependents(
 			}
 		}
 	}
-	return nil, nil
+	return droppedViews, nil
 }
diff --git a/pkg/sql/logictest/testdata/logic_test/event_log b/pkg/sql/logictest/testdata/logic_test/event_log
@@ -1,5 +1,5 @@
 # Legacy schema changer is also skipped because mutation IDs throughout log
-# entries will differ.
+# entries will differ. "event_log_legacy" file is for the legacy schema changer.
 # LogicTest: !local-legacy-schema-changer
 # knob-opt: sync-event-log
-Original file line number
+Diff line change
@@ Expand Up / @@ -555,5 +555,5 @@ func (p *planner) removeDependents( @@
     			}
     		}
     	}
-    	return nil, nil
+    	return droppedViews, nil
     }