pass all

chemelnucfin · Apr 1, 2018 · ae1b3c7 · ae1b3c7
1 parent d0d5cb8
commit ae1b3c7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/firestore/google/cloud/firestore_v1beta1/_helpers.py b/firestore/google/cloud/firestore_v1beta1/_helpers.py
@@ -129,7 +129,6 @@ def __init__(self, *parts):
             if not isinstance(part, six.string_types) or not part:
                 error = 'One or more components is not a string or is empty.'
                 import pdb
-                pdb.set_trace()
                 raise ValueError(error)
         self.parts = tuple(parts)
 
@@ -1059,8 +1058,6 @@ def pbs_for_set(document_path, document_data, option):
                             inside = True
                             break
                     if not inside:
-                        import pdb
-                        pdb.set_trace()
                         raise ValueError('Merge field is not in data.')
         except AttributeError:
             pass
@@ -1070,8 +1067,6 @@ def pbs_for_set(document_path, document_data, option):
         if transform_paths:
             transform_pb = get_transform_pb(document_path, transform_paths)
             write_pbs = [transform_pb]
-            import pdb
-            pdb.set_trace()
             return write_pbs
         else:
             raise ValueError('There is only ServerTimeStamp object.')
@@ -1107,15 +1102,15 @@ def pbs_for_set(document_path, document_data, option):
     if transform_paths:
         # NOTE: We **explicitly** don't set any write option on
         #       the ``transform_pb``.
-        import pdb
-#        pdb.set_trace()
         try:
             if option._field_paths:
                 for transform_path in transform_paths:
                     if transform_path in option._field_paths:
-        #                transform_paths = set(transform_paths) - set(field_paths)
                         transform_pb = get_transform_pb(document_path, transform_paths)
                         write_pbs.append(transform_pb)
+            else:
+                transform_pb = get_transform_pb(document_path, transform_paths)                
+                write_pbs.append(transform_pb)
         except AttributeError:
             transform_pb = get_transform_pb(document_path, transform_paths)
             write_pbs.append(transform_pb)

diff --git a/firestore/google/cloud/firestore_v1beta1/client.py b/firestore/google/cloud/firestore_v1beta1/client.py
@@ -520,8 +520,6 @@ def modify_write(
         field_paths = set(field_paths)
         if self._merge is True:
             if self._field_paths:
-                import pdb
-                pdb.set_trace()
                 new_path = None
                 for field_path in field_paths:
                     ancestor = field_path.common(self._field_paths[0])

diff --git a/firestore/tests/unit/test_cross_language.py b/firestore/tests/unit/test_cross_language.py
@@ -130,9 +130,6 @@ def run_write_test(self, test_proto, desc):
                 option = None
             call = functools.partial(doc.delete, option)
 
-        if 'set-18' in desc:
-            import pdb
-            pdb.set_trace()
         if tp.is_error:
             # TODO: is there a subclass of Exception we can check for?
             with self.assertRaises(Exception):