Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of euclidean distances in motmetrics.utils.compare_to_groundtruth() #168

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

angelcarro
Copy link
Contributor

Use euclidean distance instead of squared euclidean distance in motmetrics.utils.compare_to_groundtruth(). This way, the MOTP metric provides the expected mean distance.
The squared distance can still be used with option dist='seuc'.
#161

…e euclidean distances.

The squared distance can still be used with dist='seuc'.
@cheind
Copy link
Owner

cheind commented Aug 30, 2022

Thanks, looks good to me. Any expected side-effects to be expected? Backward compatibility?

@angelcarro
Copy link
Contributor Author

There are backward compatibility issues. If someone used the method with dist='euc' and was assuming squared euclidean distance, he/she should change to dist='seuc'.

@cheind cheind merged commit 008f45c into cheind:develop Aug 31, 2022
@cheind
Copy link
Owner

cheind commented Aug 31, 2022

thanks

@cheind
Copy link
Owner

cheind commented Aug 31, 2022

is there additional need to update the readme?

@angelcarro
Copy link
Contributor Author

Hi. I was thinking a way to mitigate the backward compatibility issues as there are some repositories that use the squared euclidean threshold such as:
https://github.com/smidm/motutils/blob/505d8359d4856c3cda7a3cf6acd4690c2dfe32d6/motutils/io.py#L297
https://github.com/iccv2021-mmp/mmp-tracking-helper/blob/d816fd04e7c896d39ac4ddc413f59318095c566b/mmp_topdown_evaluate.py#L32

I think we should add a warning when the 'euc' distance is used, suggesting to change the parameter call to dist='euc_norm' (new option) or to dist='seuc'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants