fix importing with go mod #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repositories github.com/mattn/go-colorable and github.com/mattn/go-isatty have moved to using go modules; using gopkg.in to import them breaks: golang/go#30636 Let's use the real URLs with hashes. Signed-off-by: Tycho Andersen <[email protected]>
|
@cheggaaa can you review this PR? |
|
Currently, progress bar does not work with latest go-runewidth (#142). I hope to fix it soon... |
|
I need this change as well. If you add the support for Modules, you can pin down the dependency to a specific go-runewidth version:
|
|
I gave up hope with this PR - it has been too long. I forked my own copy of this repo and made the changes myself. |
|
Sorry for the late reaction. I could not decide how to do it correctly in order to save both versions of the library and not break backward compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repositories github.com/mattn/go-colorable and
github.com/mattn/go-isatty have moved to using go modules; using gopkg.in
to import them breaks:
golang/go#30636
Let's use the real URLs with hashes.
Signed-off-by: Tycho Andersen [email protected]