Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ruby 2.5+ and test on Ruby 3.0 #71

Merged
merged 5 commits into from
Feb 1, 2021
Merged

Require Ruby 2.5+ and test on Ruby 3.0 #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6be47a
Updated the expeditor verify pipeline to test against Ruby 3.0
johnmccrae Jan 31, 2021
da54c1b
Updated the expeditor verify pipeline to test against Ruby 3.0
johnmccrae Jan 31, 2021
d966175
Merge branch 'jfm/p12update' of github.com:chef/win32-certstore into …
johnmccrae Jan 31, 2021
0585050
dropping support for Ruby 2.4 and updating the gemfile to support an …
johnmccrae Feb 1, 2021
5475a06
removed Ruby 2.4 testing altogether. Updated the gemspec file to have…
johnmccrae Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .expeditor/verify.pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ steps:
docker:
image: ruby:2.7-buster

- label: run-specs-ruby-2.4
command:
- .expeditor/run_linux_tests.sh rspec
expeditor:
executor:
docker:
image: ruby:2.4-buster

- label: run-specs-ruby-2.5
command:
- .expeditor/run_linux_tests.sh rspec
Expand All @@ -49,6 +41,14 @@ steps:
docker:
image: ruby:2.7-buster

- label: run-specs-ruby-3.0
command:
- .expeditor/run_linux_tests.sh rspec
expeditor:
executor:
docker:
image: ruby:3.0-buster

- label: "run specs :windows:"
command:
- bundle install --jobs=7 --retry=3 --without docs debug
Expand Down
5 changes: 5 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ gemspec

gem "mixlib-shellout", "< 3.0.12"

if Gem.ruby_version.to_s.start_with?("2.5")
# 16.7.23 required ruby 2.6+
gem "chef-utils", "< 16.7.23" # TODO: remove when we drop ruby 2.5
end

group :docs do
gem "yard"
gem "github-markup"
Expand Down
2 changes: 1 addition & 1 deletion win32-certstore.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
spec.summary = "Ruby library for accessing the certificate stores on Windows."
spec.homepage = "https://github.com/chef/win32-certstore"

spec.required_ruby_version = ">= 2.3"
spec.required_ruby_version = ">= 2.5"

spec.files = Dir["LICENSE", "lib/**/*"]
spec.require_paths = ["lib"]
Expand Down