Fixing deletion of a certificate by its thumbprint. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vasu1105
reviewed
Dec 28, 2018
lib/win32/certstore/mixin/crypto.rb
Outdated
| super(nil) | ||
| if str | ||
| # Converting the string to its byte array | ||
| arr = [str].pack("H*").unpack("C*") |
There was a problem hiding this comment.
we can name variable itself to something byte_arr
There was a problem hiding this comment.
Have made the changes. Thanks
Nimesh-Msys
force-pushed
the
Nimesh/MSYS-951_Fix_delete_by_thumbprint
branch
from
8b6f161 to
a8c1a16
Compare
|
@Nimesh-Msys can you rebase this against master now that I merged in #45 |
- Using the thumbprint directly to fetch a certificate - Using `CertFindCertificateInStore` with `CRYPT_HASH_BLOB` structure to achieve this. - Minor cleanup and refactor. - Minor update as per the review comment - Consider `store_name` in powershell command while fetching certificate details by thumbprint - Fixes MSYS-951 and MSYS-937 Signed-off-by: Nimesh-Msys <[email protected]>
Nimesh-Msys
force-pushed
the
Nimesh/MSYS-951_Fix_delete_by_thumbprint
branch
from
a8c1a16 to
ad7e324
Compare
Hey Tim, I've re based and updated this PR. Could you please take a look. |
|
LGTM. |
btm
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deletion of a certificate by its thumbprint.
Fetch correct certificate from the given store by its thumbprint.
Fixes: 576
Signed-off-by: Nimesh-Msys [email protected]
Description
Used
CRYPT_HASH_BLOBstructure which takesthumbprintas an input and using this struct withCertFindCertificateInStore. In this way we have tried to avoid the dependency of powershell command while deleting a certificate.Check List