Fixed all chefstyling and update configuration #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushawasthi
force-pushed
the
piyush/fix_travis_and_style
branch
from
95786c5 to
f82fb08
Compare
tas50
reviewed
Jul 12, 2018
.rubocop.yml
Outdated
| # AllCops: | ||
| # Exclude: | ||
| # - "spec/data/**/*" | ||
| # - "vendor/**/*" |
tas50
reviewed
Jul 12, 2018
| @@ -69,7 +69,7 @@ def powershell_out!(*command_args) | |||
| def run_command_with_os_architecture(script, options) | |||
| options ||= {} | |||
| options = options.dup | |||
| arch = options.delete(:architecture) | |||
| # arch = options.delete(:architecture) | |||
There was a problem hiding this comment.
If we’re not using this variable lets just remove it
Signed-off-by: piyushawasthi <[email protected]>
piyushawasthi
force-pushed
the
piyush/fix_travis_and_style
branch
from
f82fb08 to
059667b
Compare
|
@tas50 : Thanks for review, One more thing can we add appveyor badge in README. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: piyushawasthi [email protected]
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]
Check List