return only boolean on valid? method

Signed-off-by: rishichawda <[email protected]>

lib/win32/certstore.rb

@@ -114,7 +114,13 @@ def search(search_token)
     # @param request[thumbprint<string>] of certificate
     # @return [true, false] only true or false
     def valid?(certificate_thumbprint, store_location: "", store_name: "")
-      cert_validate(certificate_thumbprint, store_location: store_location, store_name: store_name)
+      cert_validate(certificate_thumbprint, store_location: store_location, store_name: store_name).yield_self do |x|
+        if x.is_a?(TrueClass) || x.is_a?(FalseClass)
+          x
+        else
+          false
+        end
+      end
     end
 
     # To close and destroy pointer of open certificate store handler

lib/win32/certstore/store_base.rb

@@ -142,6 +142,8 @@ def cert_validate(certificate_thumbprint, store_location:, store_name:)
         thumbprint = update_thumbprint(certificate_thumbprint)
         cert_pem = get_cert_pem(thumbprint, store_name: store_name, store_location: store_location)
         cert_pem = format_pem(cert_pem)
+        return "Certificate not found" if cert_pem.empty?
+
         verify_certificate(cert_pem)
       end
 

spec/win32/unit/certstore_spec.rb

@@ -300,7 +300,7 @@
       before(:each) do
         allow_any_instance_of(certbase).to receive(:get_cert_pem).and_return("")
       end
-      it "returns Certificate not found" do
+      it "returns false" do
         store = certstore.open(store_name)
         expect(store.valid?(thumbprint)).to eql(false)
       end