Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the binary install of nodejs and install yarn #2084

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Switch to the binary install of nodejs and install yarn #2084

merged 2 commits into from
Jul 29, 2021

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jul 29, 2021 •
edited
Loading

  • nodejs-binary is newer, faster to install, and easier to remove
  • install yarn to prevent the rake job from failing
  • remove sprockets which is what this was all for since it's built into rails now and we don't need double dep declarations
  • further fix the cookbook gemfile so the ctl command can install

Signed-off-by: Tim Smith [email protected]

@tas50 tas50 force-pushed the yarn_fix branch 4 times, most recently from ba0de7f to aa7a4d8 Compare July 29, 2021 03:06
@tas50
Install yarn in the supermarket def
0a1b43a 
Also remove sprockets from the gemfile now that it's built into rails.

Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 changed the title Install yarn in the supermarket def Switch to the binary install of nodejs and install yarn Jul 29, 2021
@tas50
Cookstyle fix
8dfb13d 
Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 merged commit 7ac3b50 into master Jul 29, 2021
@tas50 tas50 deleted the yarn_fix branch July 29, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tas50