Fix S3_BUCKET validation failures in buildkite + improve error messages #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our buildkite pipeline sets this now for the s3 caching of artifacts. This is new and is causing the logic that makes sure that we have all the necessary S3 env vars set to fail. Nuke that env var during the build so the logic doesn't fire. Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
S3_BUCKET deletion here doesn't do a thing since it's not in the env var at this point. Signed-off-by: Tim Smith <[email protected]>
tas50
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our buildkite pipeline sets this now for the s3 caching of artifacts.
This is new and is causing the logic that makes sure that we have all
the necessary S3 env vars set to fail. Nuke that env var during the
build so the logic doesn't fire.
Signed-off-by: Tim Smith [email protected]