-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed link for chef dk in directory file #2030
Changed link for chef dk in directory file #2030
Conversation
@@ -107,7 +107,7 @@ | |||
</li> | |||
|
|||
<li> | |||
<%= link_to 'Chef Development Kit (Chef DK)', chef_downloads_url('chef-dk') %> | |||
<%= link_to 'Chef Development Kit (Chef DK)', chef_downloads_url('tools/workstation') %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<%= link_to 'Chef Development Kit (Chef DK)', chef_downloads_url('tools/workstation') %> | |
<%= link_to 'Chef Workstation', chef_downloads_url('tools/workstation') %> |
@@ -14,5 +14,10 @@ | |||
expect(rendered).to have_selector("a[href]", text: test_kitchen_text) | |||
end | |||
|
|||
it "has chefdk link pointing to correct url" do | |||
render | |||
expect(rendered).to have_link("Chef Development Kit (Chef DK)", href: "https://downloads.chef.io/tools/workstation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect(rendered).to have_link("Chef Development Kit (Chef DK)", href: "https://downloads.chef.io/tools/workstation") | |
expect(rendered).to have_link("Chef Workstation", href: "https://downloads.chef.io/tools/workstation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update text as well
82d5798
to
1254c19
Compare
@tas50 Did the same please check |
@@ -14,5 +14,10 @@ | |||
expect(rendered).to have_selector("a[href]", text: test_kitchen_text) | |||
end | |||
|
|||
it "has chefdk link pointing to correct url" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it "has chefdk link pointing to correct url" do | |
it "has Workstation link pointing to correct url" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more change
Signed-off-by: smriti <[email protected]>
1254c19
to
349c218
Compare
Signed-off-by: smriti [email protected]
Chef Development Kit(Chef-DK) on cookbooks-directory page was pointing to wrong link. Corrected the same
Description
Chef DK link now points to https://downloads.chef.io/tools/workstation as was mentioned in the issue
Related Issue
#1975
Types of changes
Checklist: