Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump redcarpet from 3.4.0 to 3.5.1 in /src/supermarket #1904

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps redcarpet from 3.4.0 to 3.5.1. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Injection/XSS in Redcarpet Redcarpet is a Ruby library for Markdown processing. In Redcarpet before version 3.5.1, there is an injection vulnerability which can enable a cross-site scripting attack. In affected versions no HTML escaping was being performed when processing quotes. This applies even when the :escape_html option was being used. This is fixed in version 3.5.1 by the referenced commit.

Affected versions: < 3.5.1

Release notes

Sourced from redcarpet's releases.

Redcarpet v3.5.1

Fix a security vulnerability using :quote in combination with the :escape_html option.

Reported by Johan Smits.

v3.5.0

This release mostly ships with bug fixes and tiny improvements.

Improvements

  • Avoid mutating the options hash passed to a render object (See #663).

  • Automatically enable the fenced_code_blocks option passing a HTML_TOC object to the Markdown object's constructor since some languages rely on the sharp to comment code (See #451).

  • Remove the rel and rev attributes from the output generated for footnotes as they don't pass the HTML 5 validation (See #536).

  • Allow passing Range objects to the nesting_level option to have a higher level of customization for table of contents (See #519):

    Redcarpet::Render::HTML_TOC.new(nesting_level: 2..5)

Bug fixes

  • Fix a segfault rendering quotes using StripDown and the :quote option.

  • Fix SmartyPants single quotes right after a link. For example:

    [John](http://john.doe)'s cat

    Will now properly converts ' to a right single quote (i.e. ).

Changelog

Sourced from redcarpet's changelog.

Version 3.5.1 (Security)

  • Fix a security vulnerability using :quote in combination with the :escape_html option.

    Reported by Johan Smits.

Version 3.5.0

  • Avoid mutating the options hash passed to a render object.

    Refs #663.

    Max Schwenk

  • Fix a segfault rendering quotes using StripDown and the :quote option.

    Fixes #639.

  • Fix warning: instance variable @options not initialized when running under verbose mode (-w, $VERBOSE = true).

  • Fix SmartyPants single quotes right after a link. For example:

    [John](http://john.doe)'s cat

    Will now properly converts ' to a right single quote (i.e. ).

    Fixes #624.

  • Remove the rel and rev attributes from the output generated for footnotes as they don't pass the HTML 5 validation.

    Fixes #536.

  • Automatically enable the fenced_code_blocks option passing a HTML_TOC object to the Markdown object's constructor since some languages rely on the sharp to comment code.

    Fixes #451.

  • Allow passing Range objects to the nesting_level option to have a higher level of customization for table of contents:

    Redcarpet::Render::HTML_TOC.new(nesting_level: 2..5)
Commits
  • a699c82 Fix a security issue using :quote with :escape_html
  • 6270d6b Redcarpet v3.5.0
  • 94f6e27 Tiny follow-up to #663
  • 3100f65 Merge pull request #663 from maschwenk/dont-mutate-options
  • fc52d9c Add regression test
  • 03e7997 Don't mutated passed options
  • 92a7b3a Fix a segfault with StripDown and the :quote option
  • 7352162 Merge pull request #649 from rbalint/master
  • e23383e Merge pull request #650 from kolen/fix-warning-options-not-initialized
  • 6b86656 Fix "instance variable @options not initialized" warning
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added Aspect: Security Can an unwanted third party affect the stability or look at privileged information? dependencies Pull requests that update a dependency file labels Jan 11, 2021
@tas50 tas50 merged commit f9b7eed into master Jan 11, 2021
@tas50 tas50 deleted the dependabot/bundler/src/supermarket/redcarpet-3.5.1 branch January 11, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Security Can an unwanted third party affect the stability or look at privileged information? dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant