Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump kaminari from 1.0.1 to 1.2.1 in /src/supermarket #1862

Merged
merged 1 commit into from
May 29, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps kaminari from 1.0.1 to 1.2.1. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Cross-Site Scripting in Kaminari

Impact

There was a vulnerability in versions of Kaminari that would allow an attacker to inject arbitrary code into pages with pagination links.

For example, an attacker could craft pagination links that link to other domain or host: https://example.com/posts?page=4&original_script_name=https://another-host.example.com

In addition, an attacker could also craft pagination links that include JavaScript code that runs when a user clicks the link: https://example.com/posts?page=4&original_script_name=javascript:alert(42)%3b//

Releases

The 1.2.1 gem including the patch has already been released. All past released versions are affected by this vulnerability.

Workarounds

Application developers who can't update the gem can workaround by overriding the PARAM_KEY_EXCEPT_LIST constant.

module Kaminari::Helpers
  PARAM_KEY_EXCEPT_LIST = [:authenticity_token, :commit, :utf8, :_method, :script_name, :original_script_name].freeze
end
</tr></table> ... (truncated)
Affected versions: < 1.2.1

Release notes

Sourced from kaminari's releases.

v1.2.0

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

v1.1.1

Bug Fixes:

  • Fixed a bug where paginate ..., params: { controller: ..., action: ... } didn't override the params[:controller] and params[:action] #919 [@chao-mu]

v1.1.0

Enhancements:

  • Now the page_entries_info method respects the I18n.locale value when pluralizing the entry_name option #899 [@hundred]
  • require 'kaminari/core' is no longer necessary when using require 'kaminari/activerecord' #896 [@yhara]
  • Added the #current_per_page method to inspect current value of per_page #875 [@bfad]
  • Better accesibility support by adding accessibility roles to pagination nav #848 [@frrrances]

Bug Fixes:

  • Fixed an issue where the command rails g kaminari:views ... stopped working due to a missing require #912 [@jvsoares]
  • Fixed a bug where passing in params to the link_to_next_page or link_to_previous_page method raises an exception #874 [@5t111111]
Changelog

Sourced from kaminari's changelog.

1.2.1

Security Fixes:

Bug Fixes:

  • Fixed a couple of grouped total_count regressions by reverting #979

1.2.0

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

1.1.1

Bug Fixes:

  • Fixed a bug where paginate ..., params: { controller: ..., action: ... } didn't override the params[:controller] and params[:action] #919 [@chao-mu]

1.1.0

Enhancements:

  • Now the page_entries_info method respects the I18n.locale value when pluralizing the entry_name option #899 [@hundred]
  • require 'kaminari/core' is no longer necessary when using require 'kaminari/activerecord' #896 [@yhara]
  • Added the #current_per_page method to inspect current value of per_page #875 [#bfad]
  • Better accesibility support by adding accessibility roles to pagination nav #848 [@frrrances]

Bug Fixes:

... (truncated)
Commits
  • ab8b111 Version 1.2.1
  • 674aeec Merge pull request #1020 from viseztrance/fix/add-entry-to-blacklist
  • 8dd52a1 Blacklist "original_script_name" get param
  • 04d86ed Revert "Merge pull request #979 from MmKolodziej/better_total_count_for_group...
  • 7347292 kaminari supports Ruby 2.8 (or 3.0 or whatever comes next) and Rails 6.1
  • a2f262e Actually, let's call it 1.2.0
  • f901ad4 Version 1.1.2
  • c3114fa Changes for version 1.1.2
  • b21c1da using has to be called from the toplevel in Ruby 2.0
  • 795b2b7 Let this plugin internal method be super private within this file
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added Aspect: Security Can an unwanted third party affect the stability or look at privileged information? dependencies Pull requests that update a dependency file labels May 28, 2020
Bumps [kaminari](https://github.com/kaminari/kaminari) from 1.0.1 to 1.2.1. **This update includes a security fix.**
- [Release notes](https://github.com/kaminari/kaminari/releases)
- [Changelog](https://github.com/kaminari/kaminari/blob/master/CHANGELOG.md)
- [Commits](kaminari/kaminari@v1.0.1...v1.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@robbkidd robbkidd force-pushed the dependabot/bundler/src/supermarket/kaminari-1.2.1 branch from ae7b9cb to 189c7ce Compare May 28, 2020 22:17
Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbkidd robbkidd merged commit bbb117d into master May 29, 2020
@chef-expeditor chef-expeditor bot deleted the dependabot/bundler/src/supermarket/kaminari-1.2.1 branch May 29, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Security Can an unwanted third party affect the stability or look at privileged information? dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant