Resolve upcoming OpenSSL Ruby library deprecation of algorithm constants #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This change is covered by the specs around the expected output of the method using the digest. @tas50 Do you have any more details or links to the change coming in Ruby 3? I'm curious if we'll see issues elsewhere in this codebase. |
> Lint/DeprecatedOpenSSLConstant:
> Use OpenSSL::Digest.hexdigest('MD5', key_in_der_format) instead of
> OpenSSL::Digest::MD5.hexdigest(key_in_der_format).
Rubocop has a new cop[1] that detects an upcoming deprecation to the
OpenSSL gem[2] that's built into Ruby.
[1] rubocop/rubocop#7950
[2] ruby/openssl#366
The previous constant will cause failures in Ruby 3.
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Robb Kidd <[email protected]>
|
We might have some issues with our FIPS algorithm shell game then, too. |
robbkidd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rubocop has a new cop that detects an upcoming deprecation to the OpenSSL gem that's built into Ruby.
The previous constant will cause failures in Ruby 3.
Related Issue(s)
Closes #1859