Fix version validation against chef's required format #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A version for a cookbook must be either X.Y.Z or X.Y.[1] Up until this change, the validation for a CookbookVersion's version was against SemVer rules. SemVer allows for release labels or build info to appear after the version number itself. Chef does not! [1] https://docs.chef.io/cookbook_versions.html#constraints Here, we add a new ChefVersionValidator that reuses the existing version validation logic of the Chef gem in ::Chef::Version. Supermarket is already relying on the Chef gem to validate version constraints set for cookbook dependencies and supported platform. Fixes #1714 to return an error to any client if a cookbook is uploaded with an invalid version. Because cookbook versions are _Chef_ and not _Semantic_ versions, remove the Semverse dependency altogether and use Chef::Version instead. Signed-off-by: Robb Kidd <[email protected]>
In an effort to leave the camp site better than I found it, I'm replacing these direct uses of Tempfile and AndFeathers with the spec helper method that wraps this very thing. Signed-off-by: Robb Kidd <[email protected]>
This allows use of binding.pry in tests. Signed-off-by: Robb Kidd <[email protected]>
robbkidd
force-pushed
the
robb/validate-cookbook-version-against-chef
branch
from
b72b880 to
ef8d518
Compare
|
@thommay Because Supermarket is already depending on the Chef gem for |
|
This looks correct. Chef::Version is what we use to validate cookbook versions internally. |
thommay
approved these changes
Jan 18, 2018
robbkidd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A version for a cookbook must be either X.Y.Z or X.Y. Up until this change, the validation for a CookbookVersion's version was against SemVer rules. SemVer allows for release labels or build info to appear after the version number itself. Chef does not!
Here, we add a new ChefVersionValidator that reuses the existing version validation logic of the Chef gem in ::Chef::Version. Supermarket is already relying on the Chef gem to validate version constraints set for cookbook dependencies and supported platform.
Fixes #1714 to return an error to any client if a cookbook is uploaded with an invalid version.